David W. Van Couvering wrote:
I got some test failures in derbynetclient mats, so I checked the
tinderbox. We have quite a number of failures on the latest revision
that ran tests, 370061, running on Solaris 10 x86:
http://www.multinet.no/~solberg/public/Apache/TinderBox_Derby/Limited/testSummary-370061.html
derbylang: 1 failure
derbytools: 1 failure
encryptionBlowfish: 1 failure
i18nTest: 1 failure
jdbcapi: 1 failure
derbynetclientmats: 3 failures
derbynetmats: 2 failures
encryptionAll: 2 failures
encryptoin: 1 failure
derbyall: 12 failures
I just had a quick look at the errors. There were multiple IOExceptions
regarding denied access to a file. I saw an out of heap space error and
some file not found exceptions. I remember that a change of a filename
did happen lately (wisconsin?). I am a bit concerned that something may
have gone wrong in/with the test environment, so I would be ascertained
by another run to see if some of the errors disappear.
If the errors don't go away, I guess we have forgotten to update the
policy file and some tests.
I agree with you David that derbyall should in principle run without
errors. I tried to fix a test that had been failing for a long time on
Solaris 10. I would appreciate comments on the issue:
https://issues.apache.org/jira/browse/DERBY-788
I would also encourage people to close Jira issues after the fix has
verified. It helps a lot if we are able to describe how the bug can be
reproduced when we create an issue. When it comes to derbyall, I expect
that the committers have run it before commiting, and hopefully that the
developer has done it as well before the patch was submitted.
Maybe it's just me, but in my previous work with Jira, an issue wasn't
done until it is was closed.
regards,
--
Kristian
This seems a bit much; it's hard for a developer to know if their own
changes are valid as you have to sift through all the existing
failures. The last Solaris 10 x86 regression test run on revision
369861 had only 2 failures.
Looking at the derbyall history, at least on XP it seems to be getting
worse and worse (from 7 failures on 1/6 to 12 failures on 1/17). On
Solaris 10 it's gone from 1 failure to 5 failures, while on Linux it's
stayed steady.
Can those of us who have checked in/contributed patches lately please
look at the failures and see if you recognize what might be causing them?
Also: is anybody keeping an eye on these and raising a flag if the
tests start failing? I thought we had a pretty strict rule that we
should have 100% pass on derbyall.
Thanks,
David