"Bernt M. Johnsen" <[EMAIL PROTECTED]> writes: >>>>>>>>>>>>> Bernt M. Johnsen wrote (2006-02-13 10:08:47): >> >>>>>>>>>>>> Bryan Pendleton wrote (2006-02-12 19:56:12): >> > Knut Anders Hatlen (JIRA) wrote: >> > >New patch (DERBY-821-v2.diff) which addresses issues identified by >> > >Bryan and Kathey. >> > >> > This patch looks good to me. It applied cleanly to the current trunk, >> > and derbyall passed in my sandbox. Thank you for adding the additional >> > tests, I think they are quite valuable. The protocol test in >> > particular was interesting; I had not known about that technique before. >> >> >> Looks good to me too! I'll commit it as soon as Knut Anders makes I >> new version which applies cleanly to head of trunk. > > It applies cleanly. My mistake. Will commit.
Thanks, Bernt! And thank you, Bryan, for reviewing and providing helpful feedback! -- Knut Anders
