[ http://issues.apache.org/jira/browse/DERBY-902?page=all ]
Myrna van Lunteren updated DERBY-902:
-------------------------------------
Attachment: DERBY-902_021306.stat
DERBY-902_021306_2.diff
I ran derbyall with jdk15 with insane jars with the changes of this patch,
and in addition I needed it to ensure I had correctly fixed DERBY-903.
I would appreciate feedback on this patch.
changed:
- String errSeparator = new String(b);
+ String errSeparator = new String(b, "US-ASCII");
which then needed the method to throw or handle an
UnsupportedEncodingException, I made the
method throw it.
> Remove use of String(byte[]) and String(byte[], int, int) constructors in
> engine leading to non-portable behaviour
> ------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-902
> URL: http://issues.apache.org/jira/browse/DERBY-902
> Project: Derby
> Type: Bug
> Components: Network Server
> Reporter: Daniel John Debrunner
> Fix For: 10.2.0.0
> Attachments: DERBY-902_021306.stat, DERBY-902_021306_2.diff
>
> These constructors use the Java default platform encoding to convert the
> bytes to a String, this typically leads to bugs on platforms with different
> encodings.
> Replace with code using fixed conversion, or alternative mechanisms.
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.catalog.SystemProcedures
> I generated this list using the Java search in eclipse for references to the
> constructors
> String(byte[])
> String(byte[],int,int) - no occurrrences in java/engine
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
