Deepa Remesh wrote: >On 2/16/06, Kathey Marsden (JIRA) <[email protected]> wrote: > > >>I committed this patch. >>I think it would be good to add a comment to the code regarding why we use >>CheapDateFormatter and GMT. >> >>On your questions >>1. I found that the test derbynet/NSinSameJVM.java has two masters - one for >>client and one for jcc driver. These masters are identical. Can we remove >>these and keep a single copy in top "master" folder? >> >>Yes, that sounds like a good idea >> >> > >Thanks. I'll submit a follow-on patch. > > > >>2. Will it be useful to add timestamp to messages for other netwrok server >>commands (like trace, timeslice, maxthreads etc) ? >> >>I think it would be useful for all messages to the console be timestamped, >>particularly for the connection messages an any exception information. >> >> >> > >By this, do you mean all severe messages (those with ids ending with >".S" ) in org.apache.derby.loc.drda.messages_en.properties? > > > I actually think it would be good for any messages that print to the console to be timestamped. Sometimes network server prints exception information to the console especially in cases where Derby has been shutdown and it cannot accesss the error log, but this would not be related specifically to the id's. These cases pass through the console* methods such as consoleError in NetworkServerControlImpl.
Kathey
