[ 
http://issues.apache.org/jira/browse/DERBY-938?page=comments#action_12367023 ] 

Dyre Tjeldvoll commented on DERBY-938:
--------------------------------------

Thanks for your feedback.

- I'll fix the javadoc issues.

- I'll trust you on the "package protected" access issue, and fix that.

- About List and unmodifiableList: From a SW engineering point of view, I 
totally agree. However, my profiler indicates that this uses about 3 times more 
CPU. It's a tradeoff...

- Yes, voidArrayList_ should have been static.

- No the intention was that the List cannot be modified while it is traversed. 
I must admit that I don't understand why you would want to allow that (given 
that MT-access is ruled out). If you require the use of polymorphism to 
determine which elements should be removed from the container, would it not be 
better to mark those elements so that they get deleted when the iteration 
reaches their location in the container?

- Yes, I will add a comment about how the elements are ordered in the returned 
List.
 

> ContextManager needs to be optimized
> ------------------------------------
>
>          Key: DERBY-938
>          URL: http://issues.apache.org/jira/browse/DERBY-938
>      Project: Derby
>         Type: Improvement
>   Components: Performance
>     Reporter: Dyre Tjeldvoll
>     Assignee: Dyre Tjeldvoll
>     Priority: Minor
>  Attachments: derby-938.diff, derby-938.html, derby-938.v2.diff, 
> derby-938.v2.stat, derbyall_report.v2.txt, get.html, get.v2.html
>
> ContextManagers are used extensively, particularly to get access to 
> ExcutionContexts and StatementContexts. Optimizing this access should improve 
> overall performance. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to