[ http://issues.apache.org/jira/browse/DERBY-482?page=comments#action_12367241 ]
Mamta A. Satoor commented on DERBY-482: --------------------------------------- Jeff, I looked through the html file and have couple comments. 1)I don't understand the line in the first paragraph "You can specify the GENERATED ALWAYS or GENERATED BY DEFAULT options when using the procedure to define identity column values". I haven't paid close attention to changes to SYSCS_UTIL.SYSCS_IMPORT_DATA, but I don't think it needs to know if it is dealing with GENERATED ALWAYS or GENERATED BY DEFAULT. In fact, from what I know, there is no way to specify to the SYSCS_UTIL.SYSCS_IMPORT_DATA procedure whether it is dealing with GENERATED ALWAYS or GENERATED BY DEFAULT. 2)IMHO, the information on GENERATED ALWAYS and GENERATED BY DEFAULT is not flowing very smoothly on the html page. I like the format for GENERATED ALWAYS where we first give the create table sql and then 2 different forms of import files and how to use the import procedure to import from them. In addition to these 2 examples for GENERATED ALWAYS, I think it will be good to add another example where user is trying to import from a file with values for identity column data and import procedure uses that data for GENERATED ALWAYS. Such an import will fail for GENERATED ALWAYS. eg Robert,1,45.2,J Mike,2,23.4,I Leo,3,23.4,I CALL SYSCS_UTIL.SYSCS_IMPORT_DATA (NULL, 'TAB1', 'C1,C2,C3,C4' , '1,2,3,4','empfile.del',null, null,null,0) We should keep similar format for GENERATED BY DEFAULT. Show create table sql for it, and then show couple examples of import data file where the value is specified for the column or DEFAULT is specified for the column or the column values are not included in the import data file. And then for these various import files, show how data can be imported into the table with GENERATED BY DEFAULT. > GENERATED BY DEFAULT option should be documented in Derby Tools and Utilities > guide under "Importing into tables with identity columns" section. > ------------------------------------------------------------------------------------------------------------------------------------------------ > > Key: DERBY-482 > URL: http://issues.apache.org/jira/browse/DERBY-482 > Project: Derby > Type: Improvement > Components: Documentation > Versions: 10.1.1.0 > Reporter: Mamta A. Satoor > Attachments: ctoolsimportidentitycol.html, derby482.diff > > Tomohito added support for import into identity columns by adding GENERATED > BY DEFAULT option. This is documented in the Reference Guide but not in the > Tools and Utilites Guide which is where a user would look for details on > import. IMHO, there should be information about this in "Importing into > tables with identity columns" section in Tools and Utilities Guide. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
