[ http://issues.apache.org/jira/browse/DERBY-1101?page=comments#action_12370267 ]
Knut Anders Hatlen commented on DERBY-1101: ------------------------------------------- > Daniel John Debrunner commented on DERBY-1101: > ---------------------------------------------- > > Not sure why a field is needed in EmbedResultSet, when the > activation already maintains the state, it seems a bug to me that > TemporaryRowHolderResultSet is not honouring its contract. No need to have a field. (But having code in the constructor really helped exposing errors in derbyall, since the constructor is run far more frequently than getHoldability().) It seems like all places a new TemporaryRowHolderImpl is created, an Activation is readily available. Would it make sense to simply pass that activation down to the TemporaryRowHolderImpl object and further down to the TemporaryRowHolderResultSet? > ResultSet.getHoldabilty will return incorrect value when the ResultSet is > obtained from a procedure call > -------------------------------------------------------------------------------------------------------- > > Key: DERBY-1101 > URL: http://issues.apache.org/jira/browse/DERBY-1101 > Project: Derby > Type: Bug > Components: JDBC > Versions: 10.2.0.0 > Reporter: Daniel John Debrunner > Priority: Minor > Attachments: testderby1101.java > > EmbedResultSet40.getHoldability returns the holdability of the statement > returned by ResultSet.getStatement(). > When a ResultSet is created by a procedure call, its holdability may not > match the holdability of the Statement that called the procedure, which is > probably what ResultSet.getStatement() should return. > This may not be exposed as a bug yet, but I think this method should be > directly obtaining the holdability of the ResultSet using the > Activation.getResultSetHoldability() method, rather than through a Statement. > Seems a safer approach. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
