[ 
http://issues.apache.org/jira/browse/DERBY-1137?page=comments#action_12371699 ] 

Anurag Shekhar commented on DERBY-1137:
---------------------------------------

Thanks for review 
I also think seperating XAResource from XAConnection will be good idea. 

This patch can be broken into three parts
1. Sperating XAResource and XAConnection
2. Implementation of jadbc 4.0 XAConnection PooledConnection
3. Implementation of jdbc4.0 DataSource classes

If we decide to do away with XADataSource and ConnectionPoolDataSource  
implementing javax.sql.DataSource 
the patch will change substantially and can redo it in three steps.

I have changes some of the methods to make public because they were accessed 
via interface InternalXAConnection. 
If we decide to seperate the XAResource and XAConnection there won't be any 
need of this interface 
(XAResource implementation can directly use the PooledConnection, 
EmbedXAConnection and EmbedXAConnection40) 
and those methods can be left intact. 

EmbedPooledConnection40 need not be public I will change the scope of this 
class.

> Implement the new method introduced in CommonDataSource for Embedded Driver
> ---------------------------------------------------------------------------
>
>          Key: DERBY-1137
>          URL: http://issues.apache.org/jira/browse/DERBY-1137
>      Project: Derby
>         Type: Sub-task
>   Components: JDBC
>  Environment: jdk1.6 jdbc4.0
>     Reporter: Anurag Shekhar
>     Assignee: Anurag Shekhar
>      Fix For: 10.2.0.0
>  Attachments: derby-1137.diff, derby-1137_2.diff, stat.out
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to