Mayuresh Nirhali updated DERBY-836: -----------------------------------Attachment: derby836.diff
Thank you for contributing a patch for this problem. Your patch applied cleanly for me, and I was able to reproduce your results. With your new master files, but without your new code changes, the metadata test fails with the expected diff, and then when I included your code changes, the metadata test then succeeds. I was successful re-running your test in both embedded and network client. However, I have two comments on your patch: 1) I found the comment that you added to the JIRA issue to be easier to understand than the comment in the code, so I think it would be nice if you would change the comment in the code to match the comment in the JIRA issue. The JIRA issue comment is just a little less terse and easier to understand, because it lays out all three cases nicely. 2) You updated the master files for the DerbyNet framework, but I believe that is incorrect, because you didn't fix the bug in the JCC driver, only in the Network Client driver. So I think you need to revert the DerbyNet master file changes and exclude them from the patch, and I think it would be good to add a comment to the JIRA issue indicating that this bug is present in the JCC driver as well, but that we aren't (obviously) fixing it in that driver. thanks, bryan
