[ 
http://issues.apache.org/jira/browse/DERBY-1174?page=comments#action_12373979 ] 

Bernt M. Johnsen commented on DERBY-1174:
-----------------------------------------

Fix seems ok to me. 
Some nitpicking: I would prefer an if (dbProps != null) {....} around the 
for-loop instead of a conditional return in the middle of the method body....  
and an enlightening comment would also be appreciated.

> NullPointerException in network server with LDAP authentication
> ---------------------------------------------------------------
>
>          Key: DERBY-1174
>          URL: http://issues.apache.org/jira/browse/DERBY-1174
>      Project: Derby
>         Type: Bug

>   Components: Network Server, Newcomer
>     Versions: 10.1.2.1, 10.2.0.0
>  Environment: Linux x86 (Fedora Core 4), 1.4.2_09 Sun JVM
>     Reporter: Anders Morken
>     Assignee: Anders Morken
>     Priority: Minor
>  Attachments: DERBY-1174.patch, derby.log, derby.properties
>
> While trying to fix DERBY-1000 I tried to set up Derby's network server to 
> use LDAP authentication, but I ran into something that looks like a bug, but 
> could just as well be my own configuration mistake. I would appreciate any 
> help in figuring this out. =)
> The problem is a NullPointerException in the Network Server when it tries to 
> initialize the LDAP authentication service. The attached derby.log shows the 
> exception and its stacktrace. The attached derby.properties is what I put in 
> the derby home directory.
> I'm seeing this problem in the trunk as well as my own build of the 10.1 
> branch and the 10.1.2.1 release build available from the Derby web site. ( 
> http://db.apache.org/derby/releases/release-10.1.2.1.cgi )
> The problem is cause by the setInitDirContextEnv method in 
> JNDIAuthenticationSchemeBase receiving a null dbProps argument, which it 
> obviously doesn't expect. Adding a check for a null dbProps argument and 
> returning immediately after creating the initDirContextEnv object fixes the 
> NullPointerException and makes LDAP authentication work for me. This is a 
> reasonable enough robustness fix and shouldn't have any negative impact, but 
> if the source of the problem is that JNDIAuthenticationSchemeBase should 
> never receive that null pointer in the first place, more patching is needed. 
> I'm not sure about this, so I'm leaving it up to the experts to decide this. 
> =)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to