[ http://issues.apache.org/jira/browse/DERBY-900?page=all ]
Sunitha Kambhampati updated DERBY-900:
--------------------------------------
Attachment: derby900_p2_cleanup.diff.txt
derby900_p2_cleanup.stat.txt
Thanks Kathey for committing my earlier p2 encoding change patch.
It was decided earlier to break up the derby900.p2.diff.txt, so I am attaching
now a patch with the cleanup changes separately in
derby900_p2_cleanup.diff.txt. Changes are:
-- remove unnecessary conversion from sqlstate string to bytes and back to
string , in parseSQLDCGRP(Sqlca[] rowsetSqlca, int lastRow) in
NetConnectionReply.
This has been done by adding a constructor in NetSqlca to take in the sqlstate
as string.
-- cleanup method getSqlState() in Sqlca.
-- cleanup of ccsid_ in Sqlca as it is not used.
Please note, the parseSQLDCGRP method in the diff shows more changes because
of change in indentation because of removal of the try block.
-- ran derbynetclientmats on ibm142/linux OK.
Can someone please look at this. Thanks.
> Remove use of String(byte[]) and String(byte[], int, int) constructors in
> network client leading to non-portable behaviour
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-900
> URL: http://issues.apache.org/jira/browse/DERBY-900
> Project: Derby
> Type: Bug
> Components: Network Client
> Reporter: Daniel John Debrunner
> Assignee: Sunitha Kambhampati
> Fix For: 10.2.0.0
> Attachments: Derby900.p2.diff.txt, TestEnc.java, derby900.diff.p1.txt,
> derby900.p2.stat.txt, derby900.p2_encodingChange.diff.txt,
> derby900.stat.p1.txt, derby900.test.diff.txt, derby900.test.stat.txt,
> derby900_p2_cleanup.diff.txt, derby900_p2_cleanup.stat.txt,
> for_10.1_derby900.diff.p1.txt, for_10.1_derby900.stat.p1.txt
>
> These constructors use the Java default platform encoding to convert the
> bytes to a String, this typically leads to bugs on platforms with different
> encodings.
> Replace with code using fixed conversion, or alternative mechanisms.
> If the call is required its use should be commented as to why it is required.
> org.apache.derby.client.am.ClobOutputStream - some existing bug?
> org.apache.derby.client.am.DateTime - see DERBY-877
> org.apache.derby.client.am.sqlca
> I generated this list using the Java search in eclipse for references to the
> constructors
> String(byte[])
> String(byte[],int,int)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
