[ http://issues.apache.org/jira/browse/DERBY-1234?page=all ]
Knut Anders Hatlen updated DERBY-1234:
--------------------------------------
Attachment: derby-1234-part5.diff
derby-1234-part5.stat
New patch (part5) which makes all the BrokeredXXX classes check
whether the object is closed. What the patch does, is:
1) Implement checkIfClosed() and call it where needed.
2) Implement BrokeredStatement.isClosed() which was needed by
checkIfClosed().
3) Remove isWrapperFor() from BrokeredStatement40,
BrokeredPreparedStatement40 and BrokeredCallableStatement40 and
replace it by one shared method in BrokeredStatement.
With this patch, jdbc4/ClosedObjectTest.junit runs cleanly on embedded.
Derbyall and jdbc40 had no failures. Please review! Thanks.
> Verify that we raise SQLException when calling methods on closed java.sql
> objects
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1234
> URL: http://issues.apache.org/jira/browse/DERBY-1234
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Rick Hillegas
> Assignee: Knut Anders Hatlen
> Fix For: 10.2.0.0
> Attachments: derby-1234-part1.diff, derby-1234-part2.diff,
> derby-1234-part2.stat, derby-1234-part3.diff, derby-1234-part3.stat,
> derby-1234-part4.diff, derby-1234-part4.stat, derby-1234-part5.diff,
> derby-1234-part5.stat, derby-1234-v1.diff, derby-1234-v1.stat
>
> The next rev of the JDBC4 spec will clarify that databases should raise
> SQLException when an application calls methods on closed sql objects:
> ResultSet, Preparedstatement, CallableStatement, Connection, and Statement.
> We should verify that we conform.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
