[ http://issues.apache.org/jira/browse/DERBY-1308?page=comments#action_12413781 ]
Andreas Korneliussen commented on DERBY-1308: --------------------------------------------- The patch looks good. I have tested it on the jdbc40 test suite, and got no failures in the junit tests. A minor comment: utility classes like TestDataSourceFactory and TestUtil should have a private constructor to enforce noninstantiabilit, since these classes are not designed to be instantiated. Do not need to add it as part of this patch, it could be handled in a separate jira. > Tests jdbcapi/HoldabilityTest.junit, > jdbcapi/UpdateXXXTest.junit,jdbcapi/SURTest.junit fail on wctme5.7_foundation > ------------------------------------------------------------------------------------------------------------------ > > Key: DERBY-1308 > URL: http://issues.apache.org/jira/browse/DERBY-1308 > Project: Derby > Type: Bug > Components: Test, Regression Test Failure > Versions: 10.2.0.0 > Environment: derby jars used - 10.2.0.0 alpha - (400220), machine is a > win2000. > Reporter: Sunitha Kambhampati > Assignee: Myrna van Lunteren > Priority: Minor > Fix For: 10.2.0.0 > Attachments: DERBY-1308_20060524.diff, DERBY-1308_20060524.stat, > DERBY-1308_2_20060524.diff, DERBY-1308_2_20060524.stat, > DERBY-1308_3_20060527.diff, DERBY-1308_3_20060527.stat > > 05/05/2006 regression test run of derbyall shows the following test failure > with wctme5.7_foundation, > derbyall/derbyall.fail:jdbcapi/HoldabilityTest.junit > derbyall/derbyall.fail:jdbcapi/UpdateXXXTest.junit > derbyall/derbyall.fail:jdbcapi/SURTest.junit > Diff is a CNFE with ConnectionPoolDataSource. > ********* Diff file derbyall/jdbcapi/HoldabilityTest.diff > *** Start: HoldabilityTest jdkJ2ME Foundation Specification v1.0 > derbyall:jdbcapi 2006-05-07 11:31:05 *** > 0 add > > Exception in thread "main" java.lang.NoClassDefFoundError: > > javax.sql.ConnectionPoolDataSource > Test Failed. > *** End: HoldabilityTest jdkJ2ME Foundation Specification v1.0 > derbyall:jdbcapi 2006-05-07 11:31:06 *** > My guess is these tests need to excluded from running in this environment. > Can someone please confirm. Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira