[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12413941 ]
Dag H. Wanvik commented on DERBY-1313: -------------------------------------- Apart from the minor things mentioned below, I do not have further comments on this patch. Looks good to me. * DRDAConnThread.java: In the last rev, this file seems to be formatted with 8 char wide tab characters (maybe after Tomohito-san's formatting changes) and your changes seem to have been made with tab width 4, so it looks weird now. I suggest you either alert Tomohito to this (Derby uses width 4 for tabs in most cases, or preferably just whitespace), or adjust your changes to fit with tab width 8. * SURTest.java: Spurious character added on last column of line 12 (a comment line). > SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED > warnings. > --------------------------------------------------------------------------------- > > Key: DERBY-1313 > URL: http://issues.apache.org/jira/browse/DERBY-1313 > Project: Derby > Type: Bug > Components: JDBC > Reporter: Fernanda Pizzorno > Assignee: Fernanda Pizzorno > Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, > derby-1313v2.stat > > Detectability of own changes is implemented in the client using warnings cf > the write-up for DERBY-775. When a row has been deleted and/or updated, a > warning will be sent to the client to indicate that fact. Presently, only one > warning can be sent each time a data row is sent from to the client, that > means that some warnings may be lost. Using extended diagnostic allows us to > send several warnings for each data row. > I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED > warnings when necessary. This may later be extended for other warnings, but I > do not plan to do it as a part of the work in this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
