[ 
http://issues.apache.org/jira/browse/DERBY-1345?page=comments#action_12419361 ] 

Sunitha Kambhampati commented on DERBY-1345:
--------------------------------------------

I took a very quick look at this and wanted to post what I found. 

-- The code  snippet in the jira description is not in  the 10.2 codeline. My 
svn client is updated upto  417548 ( svn info).
--  But I can find this code in the 10.1 codeline in Request.java . Currently 
the server does not support EUSRIDDTA, EUSRPWDDTA which both use data 
encryption.   Thus, this code will not be used when the client is talking to 
the server. 
-- This code in writeScalarStream  in trunk ( 10.2) seems to have been 
rearranged/changed as part of DERBY-1388.

 svn log Request.java  |more 
r414562 | tmnk | 2006-06-15 04:38:26 -0700 (Thu, 15 Jun 2006) | 1 line
- DERBY-1388 Integrate processing code of two writeScalarStream methods

I have not looked closely at the changes in derby-1388, but maybe those changes 
have taken care of this issue. 

Thanks.

> net/Reply.writeScalarStream() simply prints stack trace on encryption 
> exception
> -------------------------------------------------------------------------------
>
>          Key: DERBY-1345
>          URL: http://issues.apache.org/jira/browse/DERBY-1345
>      Project: Derby
>         Type: Bug

>   Components: Network Client
>     Reporter: David Van Couvering

>
> In writeScalarStream(), the code attempts to encrypt the data, but if there 
> is any kind of exception, it simply prints the stack trace and continues.  It 
> is not clear to me that this is correct.
>             try {
>                 EncryptionManager encryptionMgr = 
> netAgent_.netConnection_.getEncryptionManager();
>                 byte[] publicKey = 
> netAgent_.netConnection_.getTargetPublicKey();
>                 encryptedBytes = encryptionMgr.encryptData(newClearedBytes,
>                         NetConfiguration.SECMEC_EUSRIDPWD,
>                         publicKey,
>                         publicKey);
>                 encryptedBytesLength = encryptedBytes.length;
>             } catch (Exception e) {
>                 e.printStackTrace();
>             }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to