[ 
http://issues.apache.org/jira/browse/DERBY-1272?page=comments#action_12419804 ] 

Kathey Marsden commented on DERBY-1272:
---------------------------------------

1) regarding build error 
Andrew said.
>Check that your java/engine/org/apache/derby/impl/services/build.xml has been 
>modified to include ${derby.tools.src.dir} in the srcdir for the compile

Yes I  do seem to have this part of the patch and tried clobber and build again 
and  seem to get the same error.

2)  Regarding testing 
Andrew said
>  I'm not sure how often tests are being run with sane builds, if at all, 
> though. 
It should  be testable with an insane build if  
derby.stream.error.logSeverityLevel=0 in one of the <test>_derby.properties 
files would be good.  Perhaps lang/errorStream test would be a good location 
but perhaps not critical as this is diagnostic info. 

3) Regarding printing regardless of  derby.stream.error.logSeverityLevel=0 with 
sane build.
My bad.  Too  long between looking at the patch and trying it #:)..  I verified 
 it does not print  if logSeverityLevel is the default with an insane build

4) Regarding aesthetic positioning.  Your reasoning makes perfect sense to me.


Short story for me is that it all looks good except for the  build error.  
However I am not so familiar with the Monitor and may not understand the 
implications especially if sysinfo fails for some reason,what the affect if any 
there might be on the server coming up, so  it would be great to see someone 
else review the code change with the next patch.


> Change sysinfo to print to error log (derby.log) on boot of derby  if 
> derby.stream.error.logSeverityLevel=0
> -----------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-1272
>          URL: http://issues.apache.org/jira/browse/DERBY-1272
>      Project: Derby
>         Type: Improvement

>   Components: Tools
>     Versions: 10.2.0.0, 10.1.2.1, 10.1.3.0
>     Reporter: Kathey Marsden
>     Priority: Minor
>  Attachments: derby-1272-pre.diff, derby-1272-pre2.diff, derby-1272-pre3.diff
>
> It is often very difficult to collect correct sysinfo output from user 
> environments because  sysinfo run from the commandline does not have the same 
> classpath as the jvm that started Derby or Derby was loaded with a custom 
> classloader.
> It would be very helpful in assisting users in diagnosing their issues if 
> sysinfo dumped to the error log if  derby.stream.error.logSeverityLevel=0  or 
> even by default.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to