[ http://issues.apache.org/jira/browse/DERBY-1015?page=comments#action_12420160 ]
Sunitha Kambhampati commented on DERBY-1015: -------------------------------------------- Please note, there are two pending patches waiting for review. derby1015.diff.txt, derby1015.p2.diff.txt. These two patches will cover the case of adding new interfaces for PreparedStatement, ResultSet, ParameterMetaData and make use of these interfaces in the server code. Since Dan already added the new interfaces for Statement and Connection., I believe with these two patches(derby1015.diff.txt, derby1015.p2.diff.txt), the cases mentioned in the jira description will be covered. As an aside, I did a search for Embed* in drda code and came across cases where the server code uses EmbedSQLException. I wonder if the server should be using EmbedSQLException or should a interface be defined for use in the server. Comments/Thoughts ? Thanks. > Define interface between network server and engine through Java interfaces. > --------------------------------------------------------------------------- > > Key: DERBY-1015 > URL: http://issues.apache.org/jira/browse/DERBY-1015 > Project: Derby > Type: Improvement > Components: JDBC > Reporter: Daniel John Debrunner > Assignee: Daniel John Debrunner > Fix For: 10.2.0.0 > Attachments: Derby1015.p2.diff.txt, derby1015.diff.txt, > derby1015.p2.stat.txt, derby1015.stat.txt > > API between the network server and engine is not well defined, leading to > inconsistent & multiple ways of handling the different objects returned, such > as reflection, explicit casting etc. This in turn has lead to bugs such as > DERBY-966 . DERBY-1005, and DERBY-1006, and access to underlying objects by > the application that should be hidden. > Define interfaces, such as EngineConnection, that both EmbedConnection and > BrokeredConnection implement. Thus the network server can rely on the fact > that any connection it obtains will implement EngineConnection, and call the > required methods through that interface. > Most likely will need EngineConnection, EnginePreparedStatement and > EngineResultSet.. These interfaces would be internal to derby and not exposed > to applications. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
