[ http://issues.apache.org/jira/browse/DERBY-551?page=comments#action_12421204 ] Deepa Remesh commented on DERBY-551: ------------------------------------
Thanks Dan for looking at the patch. I will rename the variable from PROCEDURE_CALL_ILLEGAL to MODIFIES_SQL_DATA_PROCEDURE_ILLEGAL which I think captures the case we are trying to block. About the changes to InternalTriggerExecutionContext.validateStatement, the changes I did in patch1+2 were temporary changes meant to catch the execution of DML statements in before triggers at runtime as these would not be caught by the parser. With the new patch, this case will be caught in the parser. So I reverted this code to the state before my patch. On looking at it again, I think this has been a redundant check in the first place. I will try removing this check from validateStatement. > Allow invoking java stored procedures from inside a trigger. Make CALL a > valid statement in the trigger body. > ------------------------------------------------------------------------------------------------------------- > > Key: DERBY-551 > URL: http://issues.apache.org/jira/browse/DERBY-551 > Project: Derby > Issue Type: New Feature > Components: SQL > Affects Versions: 10.1.1.0 > Environment: All platforms > Reporter: Satheesh Bandaram > Assigned To: Deepa Remesh > Fix For: 10.2.0.0 > > Attachments: derby-551-draft1.diff, derby-551-draft1.status, > derby-551-draft2.status, derby-551-draft3.diff, derby-551-draft3.status, > derby-551-patch1-v1.diff, derby-551-patch1-v1.status, > derby-551-patch2-v1.diff, derby-551-patch3-v1.diff, > derby-551-patch3-v1.status, derby-551draft2.diff, > ProcedureInTrigger_Tests_v1.html > > > Derby currently doesn't allow CALL statement to be used in a trigger body. It > would be great to allow java stored procedure invocation inside a trigger. > Since Derby doesn't have SQL procedure language, triggers can only execute a > single SQL statement. If we allow stored procedures in triggers, it would be > possible to write a trigger that involves more than just one SQL statement. > Functions are currently allowed, but they are read-only. > I believe it is fairly easy to support this enhancement. Need good amount of > testing though. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
