Thanks Knut Anders. I agree with them. I am attaching a patch to add
these comments to the code.
svn stat
M java\drda\org\apache\derby\impl\drda\DRDAProtocolExceptionInfo.java
Can someone please commit this patch if it looks ok. This patch has only
comments added, so I did ant clobber and ant all and the build went
fine. I have not run any tests.
Thanks,
Sunitha.
Knut Anders Hatlen wrote:
Sunitha Kambhampati <[EMAIL PROTECTED]> writes:
DRDAProtocolExceptionInfo has 4 fields. The comments are unclear to
me. Does anyone know what is the difference between the errorCodePoint
and the errCdCodePoint ?
I'm just guessing here, but it seems to me that errorCodePoint
specifies the code point of the error reply message, whereas
errCdCodePoint specifies the code point of an extra required field in
that reply message. Most error reply messages have one or two required
fields that are quite common, like SVRCOD (severity code) or RDBNAM
(database name). Some error reply messages additionally have required
fields that are specific to them. errCdCodePoint is used to specify
these. For instance, SYNTAXRM has a required field called SYNERRCD,
and PRCCNVRM has a required field called PRCCNVCD.
<snip examples>
Index: java/drda/org/apache/derby/impl/drda/DRDAProtocolExceptionInfo.java
===================================================================
--- java/drda/org/apache/derby/impl/drda/DRDAProtocolExceptionInfo.java
(revision 412194)
+++ java/drda/org/apache/derby/impl/drda/DRDAProtocolExceptionInfo.java
(working copy)
@@ -26,13 +26,27 @@
Holds static information about the protocol error
to put in the Hash Table
*/
- // The Codepoint of the error (e.g CodePoint.SYTNAXRM)
+
+ /**
+ * errorCodePoint specifies the code point of the error reply message,
(e.g.
+ * CodePoint.SYNTAXRM) whereas errCdCodePoint specifies the code point of
an
+ * extra required field in that reply message. Most error reply messages
+ * have one or two required fields that are quite common, like SVRCOD
+ * (severity code) or RDBNAM (database name). Some error reply messages
+ * additionally have required fields that are specific to them.
+ * errCdCodePoint is used to specify these. For instance, SYNTAXRM has a
+ * required field called SYNERRCD, and PRCCNVRM has a required field called
+ * PRCCNVCD.
+ */
protected int errorCodePoint;
// Severity Code
protected int svrcod;
- // The CodePoint describing the errCD (e.g. CodePint.SYNERRCD)
+ /**
+ * The CodePoint describing the error condition for the errorCodePoint.
+ * (e.g. CodePoint.SYNERRCD, when errorCodePoint is CodePoint.SYNTAXRM)
+ */
protected int errCdCodePoint ;
// Sends an originating Codepoint
