[ http://issues.apache.org/jira/browse/DERBY-883?page=all ]

Manish Khettry updated DERBY-883:
---------------------------------

    Attachment: 883.patch5.txt

This patch addresses issues raised by Army and Yip. 

1. Flag error for aggregate in group by list.  Changes to sqlgrammar.jj, 
SQLState.java and messages_en.properties. Other language files need to be 
changed too.

2. Remove unused SQL state (42Y19). 

3. Since the junit file (GroupByExpressionTest.java) is new, use spaces instead 
of tabs to indent. Fix indentation for long lines.

4. Remove commented out code.

5. Add a few comments suggested by Army.

6. Test ternary operator node#isEquivalent in test case.



> Enhance GROUP BY clause to support expressions instead of just column 
> references.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-883
>                 URL: http://issues.apache.org/jira/browse/DERBY-883
>             Project: Derby
>          Issue Type: New Feature
>          Components: SQL
>    Affects Versions: 10.1.2.1
>         Environment: JDK 1.5.0_05
>            Reporter: Lluis Turro
>         Assigned To: Manish Khettry
>         Attachments: 883.patch.txt, 883.patch3.txt, 883.patch4.txt, 
> 883.patch5.txt
>
>
> This select would return an error syntax on finding "(" after month if group 
> by clause:
> select idissue, month(creation), year(creation), count(distinct idissue)
> where 
>   ....
> group by idissue, month(creation), year(creation)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to