Re: [jira] Commented: (DERBY-1516) Inconsistent behavior for getBytes and getSubString for embedded versus network

[Craig L Russell]

Hi Dag,




I'll comment on your comment in the JIRA.

Thanks,

Craig

On Jul 31, 2006, at 1:16 PM, Kathey Marsden (JIRA) wrote:

I'd appreciate discussion on specific JIRA issues to be done in JIRA instead on on the mailing list. I have a hard time tracking discussions that are forked.

[ http://issues.apache.org/jira/browse/DERBY-1516? page=comments#action_12424636 ]

Kathey Marsden commented on DERBY-1516:
---------------------------------------

Thanks Craig for updating the masters.

I thiink it is really neat how specifying the patch of the same name grays out the old patches but they are still available, seems like a great way to keep our reworked patches organized. - I still think it would be good to add some 0 length test cases before we enable it to make sure behaviour is consistent between the two drivers. Linking to derby-dev discussion http://www.nabble.com/Re%3A--jira--Commented%3A-%28DERBY-1516%29- Inconsistent-behavior-for-getBytes-and-getSubString-for-embedded- versus-network-p5577797.html

Kathey

I am not sure if the two drivers are consistent in this regard or what the behavior is.

Inconsistent behavior for getBytes and getSubString for embedded versus network --------------------------------------------------------------------- ----------

                Key: DERBY-1516
                URL: http://issues.apache.org/jira/browse/DERBY-1516
            Project: Derby
         Issue Type: Bug
         Components: JDBC
           Reporter: Craig Russell
        Assigned To: Craig Russell
           Priority: Minor




            if ((pos <= 0) || (length < 0)) {

       if (length <= 0)
            throw Util.generateCsSQLException(

Attachments: DERBY-1516.patch, DERBY-1516.patch, DERBY-1516.patch org.apache.derby.client.am.Clob.getSubString(pos, length) and org.apache.derby.client.am.Blob.getBytes(pos, length) check the length for less than zero. throw new SqlException(agent_.logWriter_, "Invalid position " + pos + " or length " + length); But org.apache.derby.impl.jdbc.EmbedClob(pos, length) and org.apache.derby.impl.jdbc.EmbedBlob(pos, length) check the length for less than or equal to zero. SQLState.BLOB_NONPOSITIVE_LENGTH, new Integer (length)); The specification does not disallow length of zero, so zero length should be allowed. I believe that the implementation in org.apache.derby.client.am is correct, and the implementation in org.apache.derby.impl.jdbc is incorrect.

--
This message is automatically generated by JIRA.
-

If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/ Administrators.jspa

-

For more information on JIRA, see: http://www.atlassian.com/ software/jira

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature