[ http://issues.apache.org/jira/browse/DERBY-1544?page=all ]

Deepa Remesh updated DERBY-1544:
--------------------------------

    Attachment: d1544-patch2-v1.diff
                d1544-patch2-v1.status

Attaching a patch 'd1544-patch2-v1.diff' for the second part of this sub-task - 
grant execute privilege to 5 system routines that by default have execute 
privilege to public when a new database is created.

Changes are:
* Adds a method 'grantPublicAccessToSystemRoutines' to DataDictionaryImpl which 
is called when doing a full upgrade. This method goes through list of routines 
that needs to be granted public access and calls 
'createRoutinePermPublicDescriptor' for each routine. This is the same as the 
method that is called during database creation. It is slightly modified to 
allow specifying of an authorization id for the grantor. When upgrading, 
authorization id of user performing upgrade is used.

* Adds a test to upgrade test to verify that the 5 system routines are added to 
the routine permissions table.

With this patch, I ran the upgrade test successfully. derbyall is currently 
running. I'll post the results later.

Please note patch1 is also pending review/commit. I would appreciate any 
feedback on these patches. 

> Address remaining upgrade task(s) to complete full upgrade mechanism for 
> GRANT/REVOKE, specifically with changing database owner name from 'DBA' to 
> authorizationId of user invoking upgrade.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1544
>                 URL: http://issues.apache.org/jira/browse/DERBY-1544
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.2.0.0
>         Environment: generic
>            Reporter: Satheesh Bandaram
>         Assigned To: Deepa Remesh
>             Fix For: 10.2.0.0
>
>         Attachments: d1544-patch1-draft.diff, d1544-patch1-v1.diff, 
> d1544-patch1-v1.status, d1544-patch2-v1.diff, d1544-patch2-v1.status
>
>
> Upgrading a database from 10.1 to 10.2 should automatically change database 
> owner, recorded as owner of system schemas in sysschemas, from pseudo user 
> 'DBA' to authorizationID of the user attempting upgrade. 
> Another upgrade change I am thinking about is to grant execute privilege to 5 
> system routines that by default have execute privilege to public when a new 
> database is created. Five system routines, two compress routines and three 
> statistics related routines are given execute privilege to public when a new 
> 10.2 database is created. This is not done when a 10.1 database is upgraded 
> to 10.2 and probably good to include these privileges during database upgrade.
>  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to