[ http://issues.apache.org/jira/browse/DERBY-1164?page=all ]
Andrew McIntyre updated DERBY-1164:
-----------------------------------
Urgency: Urgent
Priority: Minor (was: Trivial)
Derby Info: [Patch Available]
Bumping the priority and urgency of this issue in the hopes of getting an extra
reviewer for this patch. I believe this is a very useful enhancement to ij for
the 10.2 release. However, I don't know if I have time to fully review *and*
test the changes before the end of this week.
I have already reviewed the changes to the ij parser and the tests provided in
the patch and they generally look good to me. However, the changes between the
_v3 and _v4 versions of the patch involve some fairly extensive changes to
JDBCDisplayUtil which, on the surface, look very good to me. The necessary
methods are overloaded to provide the new functionality for specifying columns
and display width as required by the new method calls in the parser. Because I
haven't had time to track down all of the paths through which they may be
called, I have some concern that there might be some edge cases in the modified
DisplayRow or the new getColumnDisplayWidths method or its dependents, but not
enough to vote against the patch.
The contributed tests all pass, and they look good to me, so my vote for
conributing this patch is +0.999. I'm currently running derbyall on the patch.
i have discovered a minor problem during ad-hoc testing of the patch. If you
start ij and issue a describe command before connecting to a db, it results in
a NullPointerException from which ij recovers. The problem lies in the new
getSelectedSchema method, and I believe can be easily avoided by checking that
'theConnection' that is passed to getSelectedSchema() is not null and issuing
the appropriate response if it is ('IJ ERROR: Unable to establish connection').
Despite this minor problem, I think this may still be useful to commit for
10.2. I'm curious to hear what others think. I'll report the results of
derbyall as soon as they are done.
> 'show tables' and 'describe' commands in ij
> -------------------------------------------
>
> Key: DERBY-1164
> URL: http://issues.apache.org/jira/browse/DERBY-1164
> Project: Derby
> Issue Type: New Feature
> Components: Tools
> Reporter: Håvard Mork
> Assigned To: Håvard Mork
> Priority: Minor
> Fix For: 10.2.0.0
>
> Attachments: 1164.diff, 1164_2.diff, 1164_3.diff, 1164_4.diff
>
>
> New users migrating from mysql are familiar with commands 'show tables' and
> 'describe' to respectively display all permanent tables, and show fields in
> a given table. These are not standard sql, but I suggest to implement them
> only in the IJ tool for user-friendliness.
> As suggested in db-dev, using DatabaseMetaData should provide the necessary
> query strings.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
