[ 
http://issues.apache.org/jira/browse/DERBY-1655?page=comments#action_12429467 ] 
            
A B commented on DERBY-1655:
----------------------------

Thank you Laura for taking the time to port the doc changes in _v1.html into 
the Derby 10.2 manuals.

The changes in:

  derby1655_tuning.diff 
  derby1655_tools_html.diff

look good to me and can be committed (+1).

The changes in

  derby1655_devguide.diff

are still awaiting some slight updates per my previous comment.

And below I've include a couple of (very) minor comments on the changes in the 
Reference Guide, i.e. the changes in:

  derby1655_ref.diff

NOTE: Most of these are minor enough to be left as they are, with the exception 
of those tagged with "##!##".  So if you are short on time, feel free to skip 
the minor changes and just focus on the changes tagged with "##!##".

File: rrefjdbcrefsqlxml.html
----------------------------

-- 1 --

Slight typo: can remove "to" just before "retrieve an XML" in the following 
sentence:

  You cannot instantiate a java.sql.SQLXML object in Derby,
  or bind directly into an XML value or to retrieve an XML
  value directly from a result set.

Suggested rewording (optional):

  You cannot instantiate a java.sql.SQLXML object in Derby.
  You also cannot bind directly into an XML value or retrieve
  an XML value directly from a result set.

File: rrefsqljtypexml.html
--------------------------

-- 1 --

Comment: Can we explicitly mention XMLPARSE and XMLSERIALIZE in the following 
sentence, like we do in rrefjdbcrefsqlxml.html?

  Instead, you must bind and retrieve the XML data as Java
  strings or character streams by explicitly specifying the
  appropriate XML operators as part of your SQL queries.

Suggested rewording (optional):

  Instead, you must bind and retrieve the XML data as Java
  strings or character streams by explicitly specifying the
  appropriate XML operators, XMLPARSE and XMLSERIALIZE, as
  part of your SQL queries.

-- 2 --

Slight typo: Comma between the following two sentences should be a period:

  The Java type for XML values is java.sql.SQLXML, The
  java.sql.SQLXML type is not supported by Derby.

Suggested addition (optional): can we add the word "However" at the start of 
the second sentence?  And also at the start of the second sentence in this line:

  The metadata type for XML values is SQLXML. The SQLXML type
  is not supported by Derby.

-- 3 -- ##!##

Syntax update: One of the latest checkins for XML ("phase 4" patch) added a 
restriction to the use of parameters in XMLPARSE, so the example in this file 
needs to be updated.  In particular, change

  INSERT INTO myXmlTable(xcol) VALUES XMLPARSE(
    DOCUMENT ? PRESERVE WHITESPACE) 

to be

  INSERT INTO myXmlTable(xcol) VALUES XMLPARSE (
    DOCUMENT CAST (? AS CLOB) PRESERVE WHITESPACE) 

File: rreflimitsxml.html
------------------------

-- 1 --

Slight typo: replace "are in the classpath" with "to be in the classpath" in 
the following sentence:

  Requires the JAXP parser classes, such as Apache Xerces, and
  Apache Xalan classes are in the classpath. Attempts to use XML
  operators without these classes in the classpath results in an
  error.

File: rrefsqlj33562.html
------------------------

-- 1 -- ##!##

Comment: The XML row has dashes in it, which is correct.  However the XML 
column just has blank cells.  Can we add dashes to the cells in the XML column, 
as well, to be consistent with the rest of the table?

And that's it!  Thanks for being so thorough with these.

> Document XML functionality for 10.2
> -----------------------------------
>
>                 Key: DERBY-1655
>                 URL: http://issues.apache.org/jira/browse/DERBY-1655
>             Project: Derby
>          Issue Type: Task
>          Components: Documentation
>    Affects Versions: 10.2.1.0
>            Reporter: A B
>         Assigned To: Laura Stewart
>             Fix For: 10.2.1.0
>
>         Attachments: ctoolsimport27052.html, derby1655_devguide.diff, 
> derby1655_devguide_html.zip, derby1655_ref.diff, derby1655_ref_html.zip, 
> derby1655_tools_html.diff, derby1655_tuning.diff, derby1655_tuning_html.zip, 
> DerbyXMLDoc_v1.html, DerbyXMLDoc_v2.html
>
>
> DERBY-334 and DERBY-688 have added an XML datatype and four XML operators to 
> Derby.  These are all going to be exposed to the user for general use as part 
> of the 10.2. release, so the datatype and operators need to be documented 
> accordingly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to