[ http://issues.apache.org/jira/browse/DERBY-1700?page=comments#action_12432250 ] Daniel John Debrunner commented on DERBY-1700: ----------------------------------------------
E-mail thread on the actual fact that the close cleanup method is overly complex and provides basically no benefit. http://mail-archives.apache.org/mod_mbox/db-derby-dev/200608.mbox/[EMAIL PROTECTED] Will attach a series of patches that address this incrementally. > Remove passing of closeCleanup method to every ResultSet type since only the > top ResultSet requires it. > ------------------------------------------------------------------------------------------------------- > > Key: DERBY-1700 > URL: http://issues.apache.org/jira/browse/DERBY-1700 > Project: Derby > Issue Type: Improvement > Components: SQL > Reporter: Daniel John Debrunner > Assigned To: Daniel John Debrunner > Priority: Minor > > A UNION node will generate byte code to call this method: > NoPutResultSet getUnionResultSet(NoPutResultSet source1, > NoPutResultSet source2, > Activation activation, > int resultSetNumber, > double optimizerEstimatedRowCount, > double optimizerEstimatedCost, > GeneratedMethod closeCleanup) > The closeCleanup method is passed in as null for all result sets in a tree > except the top one. Instead of passing it on each new result set, it would be > much more efficient to have a setCloseMethod() that is only called once for > the top result set. Could also look at having an closeCleanup method in the > interface and call it directly, rather than through reflection. > This applies to any node that takes a closeCleanup method. > Split out from DERBY-766 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira