[ http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12432697 ] Kathey Marsden commented on DERBY-1547: ---------------------------------------
Hello Narayan, I am back from vacation and see the testing conversation on this issue is holding it up. I think the latest suggestion actually creates a cyclical testing scenario where we would be using ProductVersionHolder to test the call to ProductVersion holder. I think this issue has become time critical as it really needs to go into a a feature release, so I think we may need to try to look at the most expedient route to get it into 10.2 and then focus on ideal testing strategies later when we have leisure to do so. To me, your original proposal to add a _sed.properties for each of the tests would be that route? Would you agree? > Add svn version number to DatabaseMetaData getDatabaseProductVersion and > getDriverVersion() to improve supportability > ----------------------------------------------------------------------------------------------------------------------- > > Key: DERBY-1547 > URL: http://issues.apache.org/jira/browse/DERBY-1547 > Project: Derby > Issue Type: Improvement > Components: JDBC > Affects Versions: 10.1.3.2 > Reporter: Kathey Marsden > Assigned To: V.Narayanan > Priority: Minor > Fix For: 10.2.1.0 > > Attachments: DERBY-1547_v1.diff, DERBY-1547_v1.stat > > > getDatabaseProductVersion and getDriverVersion() report only the four digit > Derby version number and not the svn build number. It would be useful to > return the full version including the build number as sysinfo does: e.g. > "10.1.2.4 - (392472)", That way it will be clear from application logs that > collect this information exactly what revision level they are running if they > are using rolled up fixes on the maintenance branch between releases. > There may be risk in doing this however if applications are parsing the > version information, but hopefully they will use getDatabaseMajorVersion() , > getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for > such proccessing. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
