[ http://issues.apache.org/jira/browse/DERBY-1223?page=comments#action_12433238 ] Andrew McIntyre commented on DERBY-1223: ----------------------------------------
I think the environment variables should not have the $ in front of them unless it is being used in an example. Their capitalization should be enough to distinguish their purpose in the text. cgsinstallingderby: I prefer just "distribution". Also, I think that "snapshot packages" should become "prerelease snapshots." The use of the word package after "bin, lib, and src" seems like correct usage, though. tgssetupjavaenvir: agreed, if you can run sysinfo, then java is properly set up. cgsusingtoolsutils: tools = ij, dblook, sysinfo. Utilities is used in the docs to refer to the jar and import/export system procedures, although there are other system procedures that are just as utilitarian and are not referred to as utilities. :-) scripts = any shell or batch file. I think getting started needs to only mention the tools. Considering the content, the title should probably be something like "Using the included scripts to start the Derby tools," although that could probably be worded better. Actually, I think the second sentence, "Derby's utilities include..." should be removed, along with the later references to 'utiliies,' as it's unnecessary to mention them here. For the last two comment, "if the variable is empty or not set" would be correct, but as for whether the section on chmodding the files is even necessary, I actually don't think so, since I just checked both the bin and zip distributions on a Linux box, and the execute bit was set for all of the files after unpacking them. So, I think it can be removed. > Update Getting Started to include instructions on setting JAVA_HOME variable. > ----------------------------------------------------------------------------- > > Key: DERBY-1223 > URL: http://issues.apache.org/jira/browse/DERBY-1223 > Project: Derby > Issue Type: Improvement > Components: Documentation > Affects Versions: 10.2.1.0 > Reporter: Andrew McIntyre > Assigned To: Laura Stewart > Priority: Minor > Fix For: 10.2.1.0 > > Attachments: derby1223.diff, derby1223_2.diff, Derby1223_html.zip, > derby1223_html2.zip, Derby1223_ProposedChanges.txt > > > As of the fix for DERBY-1082, the scripts were made consistent to require > setting DERBY_HOME (or DERBY_INSTALL) and JAVA_HOME. The documentation on > setting up your environment in the Getting Started guide should be updated to > reflect that these variables should be set. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
