[
http://issues.apache.org/jira/browse/DERBY-1547?page=comments#action_12435247 ]
John H. Embretsen commented on DERBY-1547:
------------------------------------------
> Andrew McIntyre commented on DERBY-1547:
> ----------------------------------------
>
> Since svn versions can be of the form {rev} or {rev}:{rev} where rev is an
> integer, and the M may or may not be attached, I think the following regex
> should match all possible values in context, allowing for only one regex to
> be added instead of two:
>
> - [(][0-9]+:*[0-9]*M*[)]
Thanks, this is great to know. Good suggestion to combine the to patterns to
one. I have only one comment:
Any reason why we should use * instead of ? for the optional characters that
will (as I understand it) occur maximum once, specifically : and M?
> Add svn version number to DatabaseMetaData getDatabaseProductVersion and
> getDriverVersion() to improve supportability
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: DERBY-1547
> URL: http://issues.apache.org/jira/browse/DERBY-1547
> Project: Derby
> Issue Type: Improvement
> Components: JDBC
> Affects Versions: 10.1.3.2
> Reporter: Kathey Marsden
> Assigned To: V.Narayanan
> Priority: Minor
> Fix For: 10.2.1.0
>
> Attachments: DERBY-1547-sed-v1.diff, DERBY-1547-sed-v1.stat,
> DERBY-1547-sed.diff, DERBY-1547-sed.stat, DERBY-1547_v1.diff,
> DERBY-1547_v1.stat, derbyall_fail.txt
>
>
> getDatabaseProductVersion and getDriverVersion() report only the four digit
> Derby version number and not the svn build number. It would be useful to
> return the full version including the build number as sysinfo does: e.g.
> "10.1.2.4 - (392472)", That way it will be clear from application logs that
> collect this information exactly what revision level they are running if they
> are using rolled up fixes on the maintenance branch between releases.
> There may be risk in doing this however if applications are parsing the
> version information, but hopefully they will use getDatabaseMajorVersion() ,
> getDatbaseMinorVersion, getDriverMajorVersion, and getDriverMinorVersion for
> such proccessing.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira