[ http://issues.apache.org/jira/browse/DERBY-1858?page=comments#action_12435725 ] Yip Ng commented on DERBY-1858: -------------------------------
Thanks for reviewing the patch, Mamta. My response to your comments: 1) Yes, I noticed that also. If you look at the CREATE_SCHEMA_PRIV and MODIFY_SCHEMA_PRIV, they are of boolean types and not like the other 7 privilege types which are declared as integers. So it looks like privilege collection for schema are done abit differently and they were not considered as an integral part of the push/pop privilege logic in compiler context. (They could be, but its not necessary) 2) The PRIV_TYPE_COUNT should still be 7 since those privilege types(select, insert, update, ..., etc.) are part of grant/revoke statement. The other schema privileges are used sorely to differentiate what action to take during permission checking time. 3) Yes, there is already a testcase to test if database owner can drop the schema. I believe I have uncommented that part of test in grantRevokeDDL2.sql to re-enable it for this jira. > A schema can be dropped by a non-schema owner in SQL authorization mode > ----------------------------------------------------------------------- > > Key: DERBY-1858 > URL: http://issues.apache.org/jira/browse/DERBY-1858 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.2.1.0, 10.3.0.0, 10.2.2.0 > Environment: Any > Reporter: Yip Ng > Assigned To: Yip Ng > Fix For: 10.2.1.0 > > Attachments: derby1858-trunk-diff01.txt, derby1858-trunk-stat01.txt > > > drop schema user2 restrict should fail since user3 does not own the schema > user2. > ij version 10.3 > ij> connect 'wombat;create=true' user 'user1' as user1; > WARNING 01J14: SQL authorization is being used without first enabling > authentication. > ij> connect 'wombat;create=true' user 'user2' as user2; > WARNING 01J01: Database 'wombat' not created, connection made to existing > database instead. > WARNING 01J14: SQL authorization is being used without first enabling > authentication. > ij(USER2)> create schema user2; > 0 rows inserted/updated/deleted > ij(USER2)> connect 'wombat;create=true' user 'user3' as user3; > WARNING 01J01: Database 'wombat' not created, connection made to existing > database instead. > WARNING 01J14: SQL authorization is being used without first enabling > authentication. > ij(USER3)> drop schema user2 restrict; > 0 rows inserted/updated/deleted > sysinfo: > ------------------ Java Information ------------------ > Java Version: 1.4.2_12 > Java Vendor: Sun Microsystems Inc. > Java home: c:\jdk142\jre > Java classpath: classes;. > OS name: Windows XP > OS architecture: x86 > OS version: 5.1 > Java user name: Yip > Java user home: C:\Documents and Settings\Yip > Java user dir: C:\work3\derby\trunk > java.specification.name: Java Platform API Specification > java.specification.version: 1.4 > --------- Derby Information -------- > JRE - JDBC: J2SE 1.4.2 - JDBC 3.0 > [C:\work3\derby\trunk\classes] 10.3.0.0 alpha - (446666) > ------------------------------------------------------ > ----------------- Locale Information ----------------- > Current Locale : [English/United States [en_US]] > Found support for locale: [de_DE] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [es] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [fr] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [it] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [ja_JP] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [ko_KR] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [pt_BR] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [zh_CN] > version: 10.3.0.0 alpha - (446666) > Found support for locale: [zh_TW] > version: 10.3.0.0 alpha - (446666) > ------------------------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
