[ 
http://issues.apache.org/jira/browse/DERBY-1808?page=comments#action_12438477 ] 
            
Daniel John Debrunner commented on DERBY-1808:
----------------------------------------------

Some changes are needed to the patch:

- remove addition of SQRTand ABS, functions are already supported by Derby

- Only JDBC escape functions that are defined by the JDBC spec are supported by 
Derby. Derby does (should) not support arbitary functions through the {fn} 
escape mechanism. This means that only SIGN should be added into the set of 
escape functions. See the comment
for EmbedDatabaseMetaData.getNumericFunctions()

- Note the signature of the RAND function is good for a built-in function, but 
does not match the signature of the JDBC escape function that needs a integer 
parameter.

- I wonder if the SIGN function should return an INTEGER?

I appreciate the url references in the javadoc for the COSH  and other methods.


> [PATCH] Inbuilt functions SIGN, SQRT, RAND, RANDOM, COSH, SINH and TANH
> -----------------------------------------------------------------------
>
>                 Key: DERBY-1808
>                 URL: http://issues.apache.org/jira/browse/DERBY-1808
>             Project: Derby
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Richard Wheeldon
>            Priority: Minor
>         Attachments: rsw_functions1.patch
>
>
> Adds the following functions:
> SIGN - 0, 1 or -1 for zero, positive or negative arguments
> SQRT - Square root
> RAND - Random number
> RANDOM - as above
> COSH - Hyperbolic Cosine
> SINH - Hyperbolic Sine
> TANH - Hyperbolic Tangent.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to