[ http://issues.apache.org/jira/browse/DERBY-183?page=comments#action_12441215 ] Bryan Pendleton commented on DERBY-183: ---------------------------------------
Hi James, thanks for the updated patch, and for the clear explanation of the LOOKAHEAD behaviors. The tests look good to me. They demonstrate the problem: they fail without the code changes, and they succeed when the code changes are applied. It is always good to have tests such as these. I had no trouble applying your patch and running the two modified tests. +1 from me to commit; is anyone else reviewing this change? > Parameter names required in CREATE FUNCTION > ------------------------------------------- > > Key: DERBY-183 > URL: http://issues.apache.org/jira/browse/DERBY-183 > Project: Derby > Issue Type: Bug > Components: SQL > Affects Versions: 10.0.2.0 > Reporter: Jack Klebanoff > Assigned To: James F. Adams > Priority: Minor > Attachments: Derby183.patch.txt, Derby183.patch2.txt > > > A statement like > create function s2.f2( char(8), integer) returns int > language java parameter style java external name 'myclass.mymethod' > fails with the message > ERROR 42X01: Syntax error: Encountered "char" at line 1, column 24 > However > create function s2.f2( p1 char(8), p2 integer) returns int > language java parameter style java external name 'myclass.mymethod' > is accepted. > The Derby documentation (at > http://incubator.apache.org/derby/manuals/reference/sqlj27.html#CREATE+PROCEDURE+Statement), > the SQL2003 standard, and DB2 all agree that the parameter name is optional. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
