[
http://issues.apache.org/jira/browse/DERBY-1893?page=comments#action_12442681 ]
Knut Anders Hatlen commented on DERBY-1893:
-------------------------------------------
I have two comments to the patch (sorry I didn't notice before it was
committed):
- the suite method should have used suite.addTestSuite(LobLengthTest.class)
instead of suite.addTest(new LobLengthTest("testXXX")). The way it is now, a
new test case won't run automatically, and one might be led to belive that it
succeeded when in fact it did not run.
- the tearDown() method should set conn to null and call super.tearDown().
Tests not doing this have caused OutOfMemoryErrors before (DERBY-1845 and
DERBY-1910). (It would be even better if the test class didn't have its own
instance variable for the connection since the BaseJDBCTestClass already has
many helper methods which remove the need for an explicit pointer to the
connection.)
> Convert largedata/lobLengthTests.java to junit
> ----------------------------------------------
>
> Key: DERBY-1893
> URL: http://issues.apache.org/jira/browse/DERBY-1893
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Øystein Grøvlen
> Assigned To: Øystein Grøvlen
> Priority: Trivial
> Attachments: derby1893.diff, derby1893.stat, derby1893_v2.diff,
> derby1893_v2.stat
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
