[ http://issues.apache.org/jira/browse/DERBY-1965?page=comments#action_12443033 ] Daniel John Debrunner commented on DERBY-1965: ----------------------------------------------
Thanks for the review - I used finally blocks to avoid having to re-write the return statement of the class since the return statement itself accessed the open socket or its streams. Yes there should be comments on the closeSocket method. > NetworkServerControlImpl never closes the socket or streams it opens in > setUpSocket. > ------------------------------------------------------------------------------------ > > Key: DERBY-1965 > URL: http://issues.apache.org/jira/browse/DERBY-1965 > Project: Derby > Issue Type: Improvement > Components: Network Server > Reporter: Daniel John Debrunner > Assigned To: Daniel John Debrunner > Priority: Minor > Attachments: derby1965_diff.txt > > > Every method that calls setUpSocket should have a call to a new > closeSocket() method. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
