[ http://issues.apache.org/jira/browse/DERBY-1758?page=all ]
A B updated DERBY-1758:
-----------------------
Attachment: d1758_followup_v1.patch
Thank you for the commit, Bryan!
I'm attaching another patch, d1758_followup_v1.patch, that moves the XML
utility methods out of junit.JDBC and into a new class, junit.XML, per Dan's
suggestion (thanks Dan).
Note that I changed the "haveClass()" method in JDBC.java from private to
protected so that it can be called from the junit.XML class. That was the
easiest thing to do.
Since checking the classpath is not a JDBC-specific operation, the other option
is to move "haveClass()" to some other class in the junit package. If anyone
indicates a preference for doing so and also indicates the class to which the
method should be moved, I can do it this way. Otherwise I'll just leave it as
it is (i.e. keep it in JDBC.java and make it protected).
I ran "suites.All" with this patch applied using jdk142 with endorsed Xalan
2.5 jars and there was one error--an OOM error with testLongLobLength(). That
was probably because I was running the suite in the background while running
other apps. In any event, I don't think that's related to this change.
As always, review comments and/or commit are appreciated.
> Enable xmlSuite to run as part of derbyall for JVMs that embed the required
> external jars.
> ------------------------------------------------------------------------------------------
>
> Key: DERBY-1758
> URL: http://issues.apache.org/jira/browse/DERBY-1758
> Project: Derby
> Issue Type: Task
> Components: Test
> Affects Versions: 10.2.1.6, 10.3.0.0, 10.2.2.0
> Reporter: A B
> Attachments: d1758_followup_v1.patch, d1758_newJUnitTests_v1.patch,
> d1758_newJUnitTests_v1.stat, d1758_newJUnitTests_v2.patch
>
>
> Due to the fact the XML support in Derby has external dependencies on Apache
> Xalan and a JAXP parser (such as, but not limited to, Apache Xerces), the
> tests for XML, which are all included in "xmlSuite", are not currently run as
> part of derbyall.
> Changes for DERBY-688 (and DERBY-567 indirectly) have now made it so that
> JVMs which have Apache Xalan and a JAXP parser embedded in them can run the
> XML tests without requiring additional jars, assuming that the embedded
> version of Xalan is at least the minimum version required by Derby (which is
> currently 2.5).
> So given that, the xmlSuite should be enabled as part of derbyall for any
> JVMs that are capable of running them. Currently, this appears to mean only
> ibm142 and ibm15.
> Per comments in DERBY-688, enabling the XML suite could include the following
> tasks:
> 1. Enable the suite to run as part of derbyall but ONLY for JVMs that
> embed the required Xalan/JAXP classes.
> 2. Resolve the following diff in lang/xmlBinding.java that occurs on
> some platforms (ex. Linux):
> < Inserted roughly 40k of data.
> 10 del
> < Inserted roughly 40k of data.
> 10a9,10
> > Inserted roughly 39k of data.
> > Inserted roughly 37k of data.
> 21 del
> < 1, [ roughly 40k ]
> 22 del
> < 2, [ roughly 40k ]
> 22a21,22
> > 1, [ roughly 39k ]
> > 2, [ roughly 37k ]
> 3. Add new tests to verify Derby behavior when XML classes are
> not present.
> Note that #3 may turn out to be its own Jira issue; the first two, however,
> should both be addressed as part of this issue since the xmlSuite will not
> run (and pass) on all platforms if either 1 or 2 is not addressed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
