[ 
http://issues.apache.org/jira/browse/DERBY-1490?page=comments#action_12447495 ] 
            
A B commented on DERBY-1490:
----------------------------

Thank you for the updated patch, Bryan.  The _v3 patch addresses all of my 
previous comments and looks great to me.

I do tend to agree with Rajesh about the presence of "ALTER TABLE" in the error 
messages--that could be slightly confusing since those words do not appear 
anywhere in the RENAME COLUMN syntax.  However, that seems like it could easily 
come as a follow-up patch to the _v3 one, if you are inclined to address it...

+1 to commit _v3 (though I don't know what came of the sqlAuthorization 
discussion; was there some resolution as to how (or if) that affects the tests 
for altertable.sql?)

> Provide ALTER TABLE RENAME COLUMN functionality
> -----------------------------------------------
>
>                 Key: DERBY-1490
>                 URL: http://issues.apache.org/jira/browse/DERBY-1490
>             Project: Derby
>          Issue Type: New Feature
>          Components: Documentation, SQL
>    Affects Versions: 10.0.2.0, 10.0.2.1, 10.1.1.0, 10.2.1.6, 10.1.2.1, 
> 10.1.3.1
>            Reporter: Bryan Pendleton
>         Assigned To: Bryan Pendleton
>         Attachments: 1490_cannot_patch.jpg, derby1490_v1_needMoreTests.diff, 
> renameColumn_v2_with_tests.diff, renameColumn_v3_after_review.diff
>
>
> Provide a way to rename a column in an existing table. Possible syntax could 
> be:
>   ALTER TABLE tablename RENAME COLUMN oldcolumn TO newcolumn;
> Feature should properly handle the possibility that the column is currently 
> used in constraints, views, indexes, triggers, etc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to