[
https://issues.apache.org/jira/browse/DERBY-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465632
]
Daniel John Debrunner commented on DERBY-2095:
----------------------------------------------
I see that you modeled 'LoadTester' on 'OperationsTester' but I think it's
overkill. This is because most of the methods in LoadTester are not testing
the Load interface, instead they are consistent across any type of load. Thus I
think the tests for the row counts can simply be moved into OETest and thus
remove the "duplicate" methods that exist now. (OETest.testOrdersRows and
LoadTester.testOrdersRows).
I like the Load interface as a concept but I'm trying to understand why the
individual table load methods exist on it and the rowsInTable method is there?
Seems like the populateAllTables() is sufficient to load the data, when would
the other methods be called through the interface?
I think the SimpleInsert should not have this constructor
public SimpleInsert(Connection conn, short scale) throws SQLException
and instead require callers to use the setupLoad on the interface.
OETest should be testing via the load interface, using setupLoad(Connection,
short) rather than the specific constructor.
Assuming the code works (testing now) I'll commit the patch shortly, and the
above items can be a later cleanup.
> Add the ability to populate a database for the order entry toolkit based upon
> the TPC-C specification.
> ------------------------------------------------------------------------------------------------------
>
> Key: DERBY-2095
> URL: https://issues.apache.org/jira/browse/DERBY-2095
> Project: Derby
> Issue Type: Sub-task
> Components: Test
> Reporter: Daniel John Debrunner
> Assigned To: Sunitha Kambhampati
> Priority: Minor
> Attachments: oe.load.p1.diff.txt
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
