Thanks for the reply, Dan. On 1/19/07, Daniel John Debrunner <[EMAIL PROTECTED]> wrote:
-0.9 on making JDBCDisplayUtil part of the public api
Well, taking it out of the public api package is certainly an easier way to go than cleaning it up. :-)
As a utility class it's not that well written, it maintains some state in static variables, which means multiple applications and/or threads using it have the potential to affect each other and thus produce unexpected results. It also would need cleanup to be able to run in a restricted SecurityManager environment. When the code was originally contributed I removed it from the public api javadoc to avoid it being used, at the time I didn't realise the tests used it so much.
Since eventually the java tests that use JDBCDisplayUtil will be rewritten as junit tests, why not go ahead and move it to impl.tools.ij? Maybe I'll go ahead and look at rewriting some of the tests that use it also. (there's currently about twelve)
I'm also not sure how many real database applications are out there that need to write ResultSet output to standard out in such a primitive form. I would guess most applications are feeding their output into HTML tables with hyperlinks or projects like BIRT that produce reports against data.
Good point. If it's not in the public API, we probably shouldn't be promoting its use in one of the demos. I'll look in to coming up with a simple replacement for the scores demo as well. andrew
