[
https://issues.apache.org/jira/browse/DERBY-2191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466413
]
Knut Anders Hatlen commented on DERBY-2191:
-------------------------------------------
Thanks Dyre, bitops.v2 looks good! I only have one tiny comment: The patch
copies this pattern (not introduced by you) from or() to and() and xor():
if (otherBit == null || otherBit.getLength() == 0)
return;
int otherLength = otherBit.getLength();
For non-empty bitsets (which I expect is the normal case) otherBit.getLength()
is called twice. It seems like all three methods will handle empty bitsets
correctly without the check for getLength()==0, so perhaps it would be better
to remove it.
> Cleanup of FormatableBitSet
> ---------------------------
>
> Key: DERBY-2191
> URL: https://issues.apache.org/jira/browse/DERBY-2191
> Project: Derby
> Issue Type: Improvement
> Components: Miscellaneous
> Affects Versions: 10.2.1.6
> Reporter: Dyre Tjeldvoll
> Assigned To: Dyre Tjeldvoll
> Priority: Trivial
> Fix For: 10.3.0.0
>
> Attachments: bitops.v1.diff, bitops.v1.stat, bitops.v2.diff,
> bitops.v2.stat, boundarycheck.v1.diff, boundarycheck.v1.stat,
> cleanup2191.diff, cleanup2191.stat, deadcode.v1.diff, deadcode.v2.diff,
> fbstst.v1.diff, fbstst.v1.stat, FormatableBitSetTest.java,
> unusedmethods.v1.diff, unusedmethods.v1.stat, valuenotnull.v1.diff,
> valuenotnull.v1.stat
>
>
> The implementation of FormatableBitSet could be streamlined. Dead code can be
> removed and the implementation of some methods can be simplified.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
