[ 
https://issues.apache.org/jira/browse/DERBY-2252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469257
 ] 

Daniel John Debrunner commented on DERBY-2252:
----------------------------------------------

Spec looks good, fairly clean, some minor clarifications/comments:

- FYI - The MethodName in a EXTERNAL NAME clause can contain a signature, 
DERBY-2271 was opened to document this.

- "Derby checks to make sure that a class by the given name lives in the jar 
file and that the class (or one of its superclasses) has a method by the given 
name. "
   Are they any specifics on the checking here, if the class is not public, if 
the method is not public and/or not static then what happens? If it's a 
procedure must the method be void? I think you said the signature checking is 
implementation defined but it would be good to clarify the behaviour for other 
situations.

- I couldn't see the need to add a FILEID column to SYS.SYSALIASES. The routine 
should be able to create a dependency on the jar file, thus hooking into the 
existing mechanism to control removing the jar file or revoking permissions.

- "An error is raised if you try to strip jar file USAGE privilege"
   Maybe picky, but by "strip" I assume you mean "REVOKE". I wonder if use of 
non-standard terms will cause confusion for non-native English speakers. Seems 
simpler & clearer to use consistent technical terms.
    


> Add Jar IDs to the EXTERNAL names in routine declarations
> ---------------------------------------------------------
>
>                 Key: DERBY-2252
>                 URL: https://issues.apache.org/jira/browse/DERBY-2252
>             Project: Derby
>          Issue Type: New Feature
>          Components: Security, SQL
>            Reporter: Rick Hillegas
>         Attachments: jarIDs.html
>
>
> This is phase (2) of the work described in the master JIRA DERBY-2206, 
> motivated by the wiki page http://wiki.apache.org/db-derby/JavaRoutineSecurity
> This task involves adding Jar IDs to the external names in CREATE PROCEDURE 
> and CREATE FUNCTION statements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to