[
https://issues.apache.org/jira/browse/DERBY-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Myrna van Lunteren updated DERBY-2293:
--------------------------------------
Attachment: DERBY-2293_20070205.diff
DERBY-2293_20070205.stat
Attaching a patch - first attempt to convert the test jdbcapi/batchUpdate.java.
The new test jdbcapi/BatchUpdateTest.java is not quite ready for commit...
I'd like reviewers especially to give input on:
- There is a method, verifyBatchUpdateCounts, which takes 2 arrays, and
compares both the length and the values resulting from the *.executeBatch()
statements.
However, in most of the test I used a two-step assertEquals approach that is
closer to what was done in the original test, it was easier to put in that way.
But which approach is easier to the reader?
- I could not use the BaseJDBCTestCase.assertStatementError(..) method for the
Batch statements, so I maintained the try-catch blocks. However, I worry that
if there is no Exception, there is no assert. The original test put statements
like this: passed=false; below the statements expecting to fail, and that value
gets evaluated later. Is that the approach I should take?
> convert batchUpdate.java to junit
> ---------------------------------
>
> Key: DERBY-2293
> URL: https://issues.apache.org/jira/browse/DERBY-2293
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Reporter: Myrna van Lunteren
> Assigned To: Myrna van Lunteren
> Priority: Minor
> Attachments: DERBY-2293_20070205.diff, DERBY-2293_20070205.stat
>
>
> Convert the test jdbcapi.batchUpdate.java to junit framework
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
