[
https://issues.apache.org/jira/browse/DERBY-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kristian Waagan updated DERBY-2247:
-----------------------------------
Attachment: derby-2247-v4-usingStoreFactory.diff
Patch 'derby-2247-v4-usingStoreFactory.diff' is equal to the previous patch,
except that white space and various other formatting issues have been fixed.
Further, the test 'TestBlobSetMethods' were renamed to 'BlobSetMethodsTest' to
follow the JUnit naming convention.
Tests ran without failures, and I committed the patch (v4) with revision 506918.
I would appreciate a follow-up patch to address some of my comments:
[LOBOutputStream]
1) Can control be final?
2) Comment why AIOOB is thrown instead of IOException?
[LOBInputStream]
3) Can control be final?
[LOBStreamControl]
4) Delete line that is commented out.
5) JavaDoc for isValidPosition and -Offset, saying that they throw exceptions.
6) Remove IOException from the throws-clause for isValidOffset?
7) In write(byte[],int,int,long), all SQLExceptions except one
(BLOB_INVALID_OFFSET) are silently ignored. Is this intended?
8) In free(), is there a chance we ignore some exceptions? If not, add a
comment? Or, if it is possible, create a RuntimeException from the PAE and
throw it as last resort?
[BlobSetMethodsTest]
9) Comment why the test is currently only run in embedded in suite().
10) I think it would be good to split the testSetBytes into one test method for
in-memory operation, and one for on disk operation.
11) In tearDown(), you could use "Statement stmt = createStatement()" and at
last call super.tearDown().
[LobStreamTest]
12) JavaDoc for testReadWriteNoParameters (and the method name) is a little off.
13) For the assertEquals comparing input and output, I think it should say
"Output does not match input" or something similar.
14) Replace assertTrue(msg, false) with fail(msg).
15) Comment why the test is currently only run in embedded in suite().
I'm not setting to fixed, as I hope there will be a follow-up patch :)
Good work! Thanks!
> provide set methods for blob in embeded driver
> ----------------------------------------------
>
> Key: DERBY-2247
> URL: https://issues.apache.org/jira/browse/DERBY-2247
> Project: Derby
> Issue Type: Sub-task
> Components: JDBC
> Environment: all
> Reporter: Anurag Shekhar
> Assigned To: Anurag Shekhar
> Priority: Minor
> Attachments: derby-2247-v3-usingStoreFactory.diff,
> derby-2247-v4-usingStoreFactory.diff, derby-2247.diff,
> derby-2247v2-using_StoreFactory.diff
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
