[ 
https://issues.apache.org/jira/browse/DERBY-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472645
 ] 

Kristian Waagan commented on DERBY-2161:
----------------------------------------

When I run the tests with this patch, I get two errors (part of derbyall):
lang/errorCode.sql
i18n/urlLocale.sql

Anyone else seeing this?
I do not see these failures when running without the patch, and I have run with 
both Sun JDK 1.5 and 1.6.
I have not investigated this at all yet.


********* Diff file derbyall/derbylang/errorCode.diff
*** Start: errorCode jdk1.6.0 derbyall:derbylang 2007-02-13 09:44:25 ***
192 del
< XBM0X|Supplied territory description '{0}' is invalid, expecting 
ln[_CO[_variant]]
193 del
< ln=lower-case two-letter ISO-639 language code, CO&|45000      
193a192
> > XBM0X|Supplied territory description '{0}' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, C&|45000 
> >      
Test Failed.



********* Diff file derbyall/i18nTest/urlLocale.diff
*** Start: urlLocale jdk1.6.0 derbyall:i18nTest 2007-02-13 12:09:21 ***
86 del
< ERROR XBM0X: Supplied territory description '' is invalid, expecting 
ln[_CO[_variant]]
87 del
< ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
87a86
> > ERROR XBM0X: Supplied territory description '' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, 
> > CO=upper-case two-letter ISO-3166 country codes, see java.util.Locale.
93 del
< ERROR XBM0X: Supplied territory description 'en_' is invalid, expecting 
ln[_CO[_variant]]
94 del
< ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
94a92
> > ERROR XBM0X: Supplied territory description 'en_' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, 
> > CO=upper-case two-letter ISO-3166 country codes, see java.util.Locale.
97 del
< ERROR XBM0X: Supplied territory description 'en_d' is invalid, expecting 
ln[_CO[_variant]]
98 del
< ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
98a95
> > ERROR XBM0X: Supplied territory description 'en_d' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, 
> > CO=upper-case two-letter ISO-3166 country codes, see java.util.Locale.
101 del
< ERROR XBM0X: Supplied territory description 'en_US_' is invalid, expecting 
ln[_CO[_variant]]
102 del
< ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
102a98
> > ERROR XBM0X: Supplied territory description 'en_US_' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, 
> > CO=upper-case two-letter ISO-3166 country codes, see java.util.Locale.
105 del
< ERROR XBM0X: Supplied territory description 'en-US' is invalid, expecting 
ln[_CO[_variant]]
106 del
< ln=lower-case two-letter ISO-639 language code, CO=upper-case two-letter 
ISO-3166 country codes, see java.util.Locale.
106a101
> > ERROR XBM0X: Supplied territory description 'en-US' is invalid, expecting 
> > ln[_CO[_variant]]\nln=lower-case two-letter ISO-639 language code, 
> > CO=upper-case two-letter ISO-3166 country codes, see java.util.Locale.
Test Failed.
*** End:   urlLocale jdk1.6.0 derbyall:i18nTest 2007-02-13 12:09:29 ***

> MessageBuilder can write the properties file using the wrong encoding.
> ----------------------------------------------------------------------
>
>                 Key: DERBY-2161
>                 URL: https://issues.apache.org/jira/browse/DERBY-2161
>             Project: Derby
>          Issue Type: Bug
>          Components: Build tools
>    Affects Versions: 10.3.0.0
>            Reporter: Daniel John Debrunner
>         Assigned To: Andrew McIntyre
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2161-v1.diff
>
>
> MessageBuilder  uses java.io.FileWriter to write the properties files which 
> picks up the default encoding, but properties files have a defined encoding 
> ISO 8859-1 with unicode esacape sequences. I don't see anything in the 
> build.xml that forces the encoding or  when running the task. Also I don't 
> see any code that implements Unicode escapes.
> I think a better approach would be to use the Properties class to write the 
> properties file, then we don't have to try and maintain the same logic for 
> formatting the output file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to