[ 
https://issues.apache.org/jira/browse/DERBY-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473214
 ] 

A B commented on DERBY-2249:
----------------------------

I unzipped the zip file into my svn codeline and ran "ant all", but the new 
files did not build.  Thus I am unable to run the test.   Is there a 
"build.xml" file missing from the zip file?  Or is there something else that I 
have to do in order get the new test files to build? (sorry if I'm missing 
something obvious).

Since I couldn't build the files I haven't tried running the test yet.  I also 
haven't started reviewing the code.  But after reading the README file I do 
have the following question...

If I'm understanding correctly this new test is, at core, a performance test.  
I.e. instead of checking for correct system functionality over a  long period 
of time, this test is attempting to measure performance of Derby for certain 
queries that may take a long time to complete.  If that's true then I think a 
better location for the new files would be the "perf" package, ex: 
derbyTesting/perf/basic/lang/, instead of the "system" package.

If the reason you chose "system" is because it's a long-running test, and if 
you would like to keep it there, then I wonder if the new test name could 
perhaps be more specific:  "RunLangTest" seems a bit vague.  Is the intent that 
other test cases will be added to this file in the future?  If so, do we know 
what kinds of tests will those be?  Can we say anything more about them than 
just that they are language tests?  If we do not expect to have other test 
scenarios added to "RunLangTest" then is it possible to rename that file to 
more accurately describe what it is testing (i.e. something to do with 
DERBY-805 and DERBY-1205)?

As for the package name "langtest", would it make sense to shorten this to 
"lang" instead of "langtest", to coincide with the existing test harness 
package names?

If there was already a discussion regarding the package and test names, then 
sorry for the noise and please feel free to point me to the relevant 
thread(s)...

Oh, and thank you for contributing this test!  I think it's safe to say that 
the more optimizer testing we can do, the better...

> Place holder to attach the long running test which will test Derby's improved 
> optimizer
> ---------------------------------------------------------------------------------------
>
>                 Key: DERBY-2249
>                 URL: https://issues.apache.org/jira/browse/DERBY-2249
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Trivial
>         Attachments: LangTest.zip
>
>
> Will be adding a test for the improved optimizer particularly to test the fix 
> for DERBY-805 and DERBY-1205. Once the files are committed will provide a 
> link to both of those issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to