[ 
https://issues.apache.org/jira/browse/DERBY-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mike Matrigali updated DERBY-2336:
----------------------------------


Note the only duplicate code I am talking about is the code that somehow gets 
the collation value for the db and puts it somewhere so that the datatype code 
can get it.  So in the current "hack" this code pushes it into the context so 
that it
can then be read from the context.  Moving it out of the context is fine, but I 
am not sure if putting it into the BasicDatabase
works for restart recovery.   If we take it out of the context where do we put 
it so that it is available to restart recovery and
to storeless engine?

I expect all the code that actually compares the datatypes to be in one place, 
in the datatype code.

I may have missed the thread, do you have an opinion on the best way for the 
datatype code to get the collation setting?
Seems like there are a few options:
1) from context (seen as a hack)
2) included as parameter to all calls that need it.  I think this will result 
in an extra parameter pushed for every call  - may
     slow down non-locale sorting.
3) somehow passed into datatype when it gets instantiated.  Note store recovery 
needs to create these things on the fly
     there is no compilation time for code to create these datatypes.
4) something else?



> Enable collation based ordering for CHAR data type.
> ---------------------------------------------------
>
>                 Key: DERBY-2336
>                 URL: https://issues.apache.org/jira/browse/DERBY-2336
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 10.3.0.0
>            Reporter: Mamta A. Satoor
>         Attachments: DERBY_LocalFinder_CodeCleanup_diff_V01.txt, 
> DERBY_LocalFinder_CodeCleanup_stat_V01.txt
>
>
> I am breaking down the Parent task DERBY-1478 (Add built in language based 
> ordering and like processing to Derby) into multiple sub tasks. One of them 
> is to concentrate on enabling the collation based ordering on (hopefully the 
> simplest of all the character data types) CHAR data type. This task in itself 
> might need subtasks if it is later found that it can be subdivided into 
> multiple smaller steps.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to