[
https://issues.apache.org/jira/browse/DERBY-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478566
]
Dag H. Wanvik commented on DERBY-2404:
--------------------------------------
Looks good to me! I agree setUp time is fine here.
+1
> BadConnectionTest.java hardcodes port 1527
> ------------------------------------------
>
> Key: DERBY-2404
> URL: https://issues.apache.org/jira/browse/DERBY-2404
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Dag H. Wanvik
> Assigned To: Andrew McIntyre
> Priority: Minor
> Attachments: derby-2404-v1.diff, derby-2404-v2.diff
>
>
> This test references port 1527; it should use the current test
> configuration's method getPort instead, to make it possible to run
> several tests on the same machine concurrently.
> When I experimented and changed TestConfiguration.DEFAULT_PORT to
> something else but 1527, running suites.All crashed in
> BadConnectionTest.java, and also crashed the JUnit textui.TestRunner
> with this message: "Couldn't get I/O for the connection to:
> localhost". No failure explanation or stack trace was printed on the
> console. Not sure why...
> Running the test separately, the testrunner survived to show the
> failures.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
