[ 
https://issues.apache.org/jira/browse/DERBY-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481105
 ] 

Dyre Tjeldvoll commented on DERBY-2114:
---------------------------------------



Sounds like a good idea.


Well, honestly I've not considered how well StatementCache was
implemented, as this wasn't my itch. That said, I'm sure a lot could
be done. But why create two copies? Why not just return a Vector of
PreparedStatements directly, then?

-- 
dt


> Let Clock embed a HashMap rather than inherit from Hashtable
> ------------------------------------------------------------
>
>                 Key: DERBY-2114
>                 URL: https://issues.apache.org/jira/browse/DERBY-2114
>             Project: Derby
>          Issue Type: Improvement
>          Components: Performance
>    Affects Versions: 10.2.1.6
>            Reporter: Dyre Tjeldvoll
>         Assigned To: Dyre Tjeldvoll
>            Priority: Trivial
>             Fix For: 10.3.0.0
>
>         Attachments: derby-2114.v1.diff, derby-2114.v1.stat
>
>
> Clock currently inherits from Hashtable, but the use of Hashtable is really 
> an implementation detail that would benefit from being hidden as private 
> member. All access to the hashtable happens inside sychronized blocks so it 
> is safe to substitute a HashMap. This change appears to trigger a small 
> increase in throughput, as measured by the average TPS number obtained by 
> running the select client from DERBY-1961 repeatedly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to