[
https://issues.apache.org/jira/browse/DERBY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481772
]
Jean T. Anderson commented on DERBY-2458:
-----------------------------------------
I took a look at your patch and have several comments.
I like your addition of a assertColumnTypes method to JDBC.java. And I really
like your use of assertions. Your usage of JDBC.assertFullResultSet,
assertCompileError, and other methods is a good reminder to me to check where I
should be using more of what others have already defined.
Here are a couple things I think could be changed:
- setUp() needs a stmt.close()
- Two test methods create a SQL function, but don't drop it. I didn't encounter
problems when I ran your suite (both client and embedded), but I wonder if that
might create a problem in some context.
- Take a pass through the code and verify that the javadoc comments match the
code; I know how easy it is for them to get out of sync while developing.
For example, the javadoc comment for setUp() doesn't match what it does. You
might consider simplifying the description to something like "Create and
populate test tables.". That would reduce maintenance later if more tables
get added, their names change, or more rows get inserted.
> Convert lang/unaryArithmeticDynamicParamter.java to junit
> ---------------------------------------------------------
>
> Key: DERBY-2458
> URL: https://issues.apache.org/jira/browse/DERBY-2458
> Project: Derby
> Issue Type: Test
> Components: Test
> Affects Versions: 10.3.0.0
> Reporter: Manjula Kutty
> Assigned To: Manjula Kutty
> Priority: Trivial
> Fix For: 10.3.0.0
>
> Attachments: DERBY-2458_diff_03_16.txt, DERBY-2458_diff_ver1.txt,
> DERBY-2458_stat_ver1.txt
>
>
> Place holder to convert lang/unaryArithmeticDynamicParameter.java to junit
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
