[ https://issues.apache.org/jira/browse/DERBY-2412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484059 ]
Bernt M. Johnsen commented on DERBY-2412: ----------------------------------------- Dan: I see your point, and I will consider your approach, depending of the nature of the remaining problems. ( And, yes Gran Canaria was a vacation, I was not able to acces worm mail ;-) Rick: Good idea with a CommandArg clss, but that should be done as a separate iteration (ref Dan's comment). > Refactor NetworkServerControlImpl > --------------------------------- > > Key: DERBY-2412 > URL: https://issues.apache.org/jira/browse/DERBY-2412 > Project: Derby > Issue Type: Improvement > Components: Network Server > Reporter: Bernt M. Johnsen > Assigned To: Bernt M. Johnsen > Priority: Minor > Attachments: derby-2412-v1.diff, derby-2412-v1.stat > > > NetworkServerControlImpl is overly complex and serves several purposes. This > makes it hard to penetrate the logic, to debug and to maintain. > I propose (actually, I've alread done a whole lot) to tear it apart and move > the current semantics into the following new classes: > NetworkServer - the actual network server code > NetworkAdminServer - the implementation of network administration commands > (ping, shutdown etc) > NetworkAdminClient - the client for network administration of Derby > NetworkAdminProtocol - the administration command protocol (as opposed to the > DRDA protocol) > plus a couple of utility classes (common methods, common constants, error > messaging, exceptions etc) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.