[
https://issues.apache.org/jira/browse/DERBY-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484437
]
Knut Anders Hatlen commented on DERBY-2443:
-------------------------------------------
Thanks for the new patch, Narayanan! I have committed it with revision 522873.
One more minor comment: jdbcapi/UpdatableResultSetTest.java has two methods,
fetch() and fetchUpd(), which create statements without closing them. I don't
know if it's a problem here, but other JUnit tests have occasionally failed
because statements or result sets were not closed and some resources were held
until they were garbage collected. Perhaps it would be good to rewrite them so
that the statements could be closed?
> Implement ResultSet updateClob/updateBlob methods on the NetworkClient
> -----------------------------------------------------------------------
>
> Key: DERBY-2443
> URL: https://issues.apache.org/jira/browse/DERBY-2443
> Project: Derby
> Issue Type: Improvement
> Components: Network Client
> Environment: All
> Reporter: V.Narayanan
> Assigned To: V.Narayanan
> Attachments: ResultSetNotImplMethods_v1.diff,
> ResultSetNotImplMethods_v1.stat, ResultSetNotImplMethods_v2.diff,
> ResultSetNotImplMethods_v2.stat, ResultSetNotImplMethods_v3.diff,
> ResultSetNotImplMethods_v3.stat
>
>
> Implement the following ResultSet methods on the Network Client
> updateBlob(int columnIndex, Blob x)
> updateBlob(String columnName, Blob x)
> updateClob(int columnIndex, Clob x)
> updateClob(String columnName, Clob x)
> updateBlob(int columnIndex, InputStream x, long length)
> updateBlob(String columnName, InputStream x, long length)
> updateClob(int columnIndex, Reader x, long length)
> updateClob(String columnName, Reader x, long length)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
