[
https://issues.apache.org/jira/browse/DERBY-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12485559
]
A B commented on DERBY-2487:
----------------------------
I have not looked at the code changes for this issue, nor have I actually tried
out the new functionality. I plan to, but I have not yet had enough time.
I did, however, apply the full patch (it applied cleanly) and I ran Derby's
primary two regression suites ("derbyall" and "suites.All") on Red Hat Linux
with ibm142. A handful of tests failed in "derbyall" because of metadata
differences: namely, the metadata now includes information for the new XPLAIN
stored procedures. This means the expected results for those tests have to be
updated to reflect the presence of the new procedures. Unfortunately, I
accidentally deleted the derbyall results so I do not have a list of the tests
which require updates. However, if you run
java org.apache.derbyTesting.functionTests.harness.RunSuite derbyall
on your machine, you should hopefully be able to see the failures for yourself.
Note that the "derbyall" suite takes three to four hours to complete (on my
test machine). If you are uncertain about how to fix the tests, please feel
free to ask questions to derby-dev.
Aside from the metadata failures, derbyall ran cleanly. As for "suites.All" I
saw 5 failures:
FAILURES!!!
Tests run: 5664, Failures: 5, Errors: 0
I have not had time to look into the cause of the failures; can you run this
suite and investigate a bit more?
java junit.swingui.TestRunner -noloading
org.apache.derbyTesting.functionTests.suites.All
This regression suite usually takes less than an hour to complete.
As for the patch itself, it is a very large patch. I count over 10,000 lines
of code changes in all (including comments). As Bryan said earlier, it is
probably going to take a while for people to read and review it. It might help
if you were able to break the patch up into smaller logical "pieces", where
each piece compiles cleanly and passes the regression suites. It is generally
much easier to review smaller patches, and you are more likely to get comments
from more people in a shorter time. See:
http://wiki.apache.org/db-derby/PatchAdvice
http://wiki.apache.org/db-derby/IncrementalDevelopment
Of course that is just a suggestion; you are not required to post incremental
patches.
Also note the following, copied from the Derby wiki page:
http://wiki.apache.org/db-derby/DerbyContributorChecklist
"If you are attaching a large patch, you should sign an [WWW] ICLA, generally
granting Apache license rights over your Derby contributions. Evidence that you
filed an ICLA is supposed to appear in the [WWW] Contributors list. However,
since Apache updates this list only sporadically, you may need to resubmit your
ICLA or pester Apache to notice it. For more information, see the [WWW] Apache
licensing info."
I think 10k lines counts as "a large patch", so it'd be great if you could sign
an ICLA :) The wiki page at the above URL has the necessary links. If you
have already filed an ICLA then it might be helpful if you could indicate that
in an email or as a comment for this issue.
And one final suggestion:
Don't be shy! If at any point you have any questions about Derby--whether they
relate to this Jira or not--please feel free to ask them on derby-dev or on
derby-user. And if you have input/answers to other people's
questions/discussions, please chime in at any point. We welcome your
participation.
> Enhance Derby with EXPLAIN Functionality
> ----------------------------------------
>
> Key: DERBY-2487
> URL: https://issues.apache.org/jira/browse/DERBY-2487
> Project: Derby
> Issue Type: New Feature
> Components: SQL
> Affects Versions: 10.2.2.0
> Reporter: Felix Beyer
> Priority: Minor
> Attachments: Derby physical XPLAIN schema.png, RSProtocolNew.pdf,
> rts.xls, small logical xplain schema.pdf, usage.txt, xplain_patch_v1.txt,
> xplainClasses.pdf
>
>
> This enhancement extends Derby with EXPLAIN functions. Users want to have
> more feedback than they`re getting with the current RuntimeStatistics
> facility. This extension is based on the
> RuntimeStatistics/ResultSetStatistics functions / classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
